visual mode: gj/gk not working in wrapped lines

This is based on issue #90 but for visual mode instead of normal mode. Currently it is not possible to jump over wrapped lines with gj/gk when visual mode is on.

I tried to copy these lines: https://github.com/asvetliakov/vscode-neovim/blob/6469c216f30c4bf29d5718f6d3fe99d517a33db0/vim/vscode-motion.vim#L15-L16

and changed them to vnoremap:

vnoremap gk <Cmd>call VSCodeNotify('cursorMove', { 'to': 'up', 'by': 'wrappedLine', 'value': v:count ? v:count : 1 })<CR> 
vnoremap gj <Cmd>call VSCodeNotify('cursorMove', { 'to': 'down', 'by': 'wrappedLine', 'value': v:count ? v:count : 1 })<CR> 

Afterwards the movement works but it doesn’t update the selection. Here the cursor is in line 17 but the selection is still stuck in line 18.

I checked the API and there is the select argument for cursorMove.

vnoremap gk <Cmd>call VSCodeNotify('cursorMove', { 'to': 'up', 'by': 'wrappedLine', 'value': v:count ? v:count : 1, 'select': true})<CR>
vnoremap gj <Cmd>call VSCodeNotify('cursorMove', { 'to': 'down', 'by': 'wrappedLine', 'value': v:count ? v:count : 1, 'select': true})<CR

But i get an error that the variable true is undefined: emsg: E121: Undefined variable: true

Any ideas how i can use the select argument?

[jweickm]

That’s too bad. Would love to see this functionality added into VSCode Neovim.

[theol0403]

Not a priority, but the problem is that vscode moves the cursor but then does not tell nvim about the new cursor position to extend the visual selection. Either the gj/gk hack could be removed, or there needs to be some code that extends the visual selection.