Moving the cursor to somewhere outside of the viewport should center the cursor vertically

Describe the bug A couple of examples of the situation described in the title:

• When jumping to a mark outside of the viewport, the cursor line is placed at either the first or second from last line in the viewport.
• When searching for a string with / and the next occurrence is outside of the viewport, the cursor line is placed at either the first or second from last line in the viewport.

To Reproduce Steps to reproduce the behavior:

1. Set a mark at line x in a file with ma.
2. Navigate to another part of the file such that the line x is outside of the viewport.
3. Jump to the mark with 'a.

Expected behavior The cursor line x should be vertically centered.

Screenshots

Environment (please complete the following information):

• Extension (VsCodeVim) version: 0.16.0
• VSCode version: 1.25.1
• OS: Windows 10

[pnalchajian]

The above commit (4434) seems to behave unexpectedly around heavily folded code. If I’m traversing lines (simple cursor movements like jk) in a non-folded section of code, the cursor works just fine. When I’m doing the same amidst many folds, cursor navigation behaves almost like a scrollOffset is set (keeping the cursor in the center always).

[naseer]

Looks like zz is the binding I was looking for 😃 Still would be nice if the cursor was centered by default after the search.