otherModesKeyBindings does not work in Visual mode

Is this a BUG REPORT or FEATURE REQUEST? (choose one): Bug Report

What happened: Remapping a key in vim.otherModesKeyBindings works in Command mode but not Visual mode

What did you expect to happen: I expected the key to behave the same in both modes.

How to reproduce it (as minimally and precisely as possible):

"vim.otherModesKeyBindings":  [
        {
            "before": ["s"],
            "after": ["<Nop>"]
        }
]

You’ll notice that the key is unbound in Command mode, but still active in Visual mode.

Environment:

• Extension (VsCodeVim) version: 0.12.0
• VSCode version: 1.24.1
• OS version: OSX 10.12.6

[dylanscott]

It looks like otherModeKeybindings was renamed normalModeKeybindings in this commit.

This is the second time I’ve had my keybindings broken by an update and required me to read look through the commit history for this extension to fix them. It’s very frustrating. I don’t understand why you wouldn’t make a change like this in a backwards compatible way that wouldn’t break people currently using otherModeKeybindings.

[jpoon]

@dylanscott this was mentioned in our changelog – https://github.com/VSCodeVim/Vim/blob/master/CHANGELOG.md#v0130-2018-06-18. I also put out a notice on our Slack that this was coming. If you have any ideas on how to better communicate these things, would love to hear suggestions.

We decided not to make it backwards compatible as that setting doesn’t really make any sense anymore. If we did make it backwards compatible we would then have remappers for insert, normal, visual, and other, where “other” would mean normal and visual for backwards-compat, and that makes it super confusing.