question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Proposition: Keep configs in the same repo

See original GitHub issue

Hey, I see that currently there are two repositories:

  • eslint-plugin-vue
  • eslint-config-vue

Not everyone knows, but you can actually keep everything in one repository which makes maintaining far easier and releasing new versions less troubleprone (Example configs in eslint-plugin-ember repo).

I also recommend creating two configs:

  • base
  • recommended

This way we can keep all necessary settings in base config, and recommended settings for eslint-plugin-vue in the second file, which will basically extend base config with recommended settings for each new rule.

This will make the configuration even easier:

module.exports = {
  extends: [
    'eslint:recommended',
    'plugin:vue/recommended'
  ],
  rules: {
    // override rules' settings here
  }
}

I’m willing to work on this one if you agree with me.

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:11 (10 by maintainers)

github_iconTop GitHub Comments

2reactions
yyx990803commented, May 29, 2017

I’m starting to think we should separate the use cases a bit more explicitly - it seems many users are thinking they should use eslint-plugin/config-vue in their applications, whereas they were actually created for Vue’s own library code.

Here’s I think what we should do:

  1. Create a separate plugin eslint-plugin-vue-libs, used by official Vue libraries, replacing the current eslint-config-vue + eslint-plugin-vue combination.

  2. Rework eslint-plugin-vue to be the new user-facing plugin that should be used in Vue applications. The plugin would only contain Vue-specific rules, and can be layered about a base JS config of choice (e.g. eslint/recommended, standard, or airbnb).

Also,there’s a ton of work being done in https://github.com/mysticatea/eslint-plugin-vue-trial e.g. infrastructure code for traversing and checking the template AST - I’d really like @mysticatea to collaborate with us on the official plugin 😃

1reaction
yyx990803commented, Jun 1, 2017

Ok, so I have:

  • Created eslint-plugin-vue-libs and moved all internal projects to use that instead.

  • Invited @mysticatea as a collaborator on this repo so that he can start moving his work under a dev branch here.

  • Deprecated eslint-config-vue since configs will be part of this plugin. Further work should also be done in this repo.

Also @michalsnik if you are interested, I can add you as a collaborator too 😃

Read more comments on GitHub >

github_iconTop Results From Across the Web

Since the configuration file is kept in the same repository as ...
We deploy code to 3 datacenters so we simply have 3 config files in the repository. Deploy script then decides to link the...
Read more >
Storing different configuration for the same application in a ...
First, I would heavily recommend against using branches for customization, even when the kind of customization will be as simple as ...
Read more >
Config as Code strategies - Octopus Deploy
We recommend keeping your deployment configuration in the same repository as the application code, but there are specific circumstances ...
Read more >
Add configs to Git repositories | Anthos Config Management
A config is a YAML or JSON file that is stored in a Git repository. Configs contain the same type of configuration details...
Read more >
GitOps - Config in same repo or seperate repo? - Stack Overflow
One catch is that a single version of the app will normally need to support multiple deployments and the deployment config can often...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found