question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

upgrading vls from 0.5 to 0.6 breaks atom-ide-vue

See original GitHub issue
  • I have searched through existing issues
  • I have read through docs
  • I have read FAQ -> This link does not exist.
  • I have tried restarting VS Code or running Vetur: Restart VLS -> N/A

Info

  • Platform: Win 10
  • Vetur version: -> Vls 0.6
  • VS Code version: N/A

atom-langaugeclient has these dependencies: “vscode-jsonrpc”: “5.0.1”, “vscode-languageserver-protocol”: “3.15.3”, “vscode-languageserver-types”: “3.15.1”

Problem

Hi. The atom-ide-vue maintainer here. I recently updated vls from 0.5 to 0.6, but that broke the server and the plugin (datatips, autocomplete, etc). So I had to downgrade to 0.5.

Here is the code for atom-ide-vue. As you see, it is minimal because most of the work is handled by atom-languageclient which uses vscode-languageserver underneath. https://github.com/atom-ide-community/atom-ide-vue/blob/master/lib/main.js

I could not find a changelog for vls to see the changes.

These are the kind of errors that we get: image

We have an issue for it: https://github.com/atom-ide-community/atom-ide-vue/issues/35#issuecomment-743697912

Reproducible Case

  • Install Atom.
  • apm install language-vue atom-ide-base atom-ide-javascript
  • git clone https://github.com/atom-ide-community/atom-ide-vue
  • cd atom-ide-vue
  • npm install
  • npm install vls@0.6
  • apm link .
  • cd spec/project/hello-world
  • atom .
  • CTRL+SHIFT+F5 to open dev tools
  • open App.vue

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:2
  • Comments:5 (3 by maintainers)

github_iconTop GitHub Comments

2reactions
aminyacommented, Dec 12, 2020

Thanks! I will fix it in a PR.

1reaction
yoyo930021commented, Dec 12, 2020

Thank you so much! @yoyo930021 I tested it, and now it works as expected!

I expect workspaceFolders: null in InitializeParams when client no support workspace. but atom-languageclient send workspaceFolders: [].

Is this nullness part of the spec? or it should be []? or it is not specified?

I can send a PR to atom-languageclient to fix these.

https://microsoft.github.io/language-server-protocol/specifications/specification-current/#initialize

截圖 2020-12-12 下午4 00 19
Read more comments on GitHub >

github_iconTop Results From Across the Web

vuejs/vetur (Raised $789.00) - Issuehunt
upgrading vls from 0.5 to 0.6 breaks atom-ide-vue. Unfunded#2561created byaminya. $0.00. [Question] How does Vetur discover the components in a project and ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found