question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[ RFC ] Global color modifiers

See original GitHub issue

I’ve discussed with @filrak about creating common modifiers for components globally (as Bulma does), at least for colors.

So, some classes like has-bg-primary and has-text-primary should be created and available for all convenient components, then these components shouldn’t have BEM modifiers specifically for the primary color.

Imo we should create these modifiers for primary, secondary, danger, warning, info and success colors, wdyt? The respective modifiers should be removed from components, we should use the global ones instead.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Reactions:4
  • Comments:5

github_iconTop GitHub Comments

2reactions
leomp12commented, Jun 24, 2019

@filrak sure, I’ll take care of it.

@mayashavin about sizes, I think it may be available for almost all atoms, right? Although, I think it would be component specific, we can use modifiers with the same class names, but imo .sf-price.lg should apply different styles than .sf-button.lg for example, wdyt?

2reactions
mayashavincommented, Jun 24, 2019

@leomp12 @filrak I agree on the global ones. We should have a global palettes and global sizes, this way we don’t need to define again specific modifiers and make it harder to control the styling. You can check the implementation of the size in SfIcon. I would suggest we define something more specific rather than pink-primary and pink-secondary also.

Read more comments on GitHub >

github_iconTop Results From Across the Web

[ RFC ] Global color modifiers · Issue #209 - GitHub
Imo we should create these modifiers for primary , secondary , danger , warning , info and success colors, wdyt? The respective modifiers...
Read more >
RFC 7950: The YANG 1.1 Data Modeling Language
RFC 7950 YANG 1.1 August 2016 o identity: A globally unique, abstract, ... For example, the following is illegal: leaf color { type...
Read more >
CSS Color Module Level 4 - W3C
CSS provides several methods of directly specifying an sRGB color: hex colors, rgb()/rgba() color functions, hsl()/hsla() color functions, hwb() ...
Read more >
The YANG 1.1 Data Modeling Language RFC 7950
1. o Defined the string value of an identityref in XPath expressions (see Section 9.10). o Clarified what unprefixed names mean in leafrefs...
Read more >
UTS #51: Unicode Emoji
Table: Sample Emoji Modifier Bases; Table: Expected Emoji Modifiers Display ... In other words, when someone changes the text color in a word...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found