question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Desktop/Mobile] Implement SfModal

See original GitHub issue

image

Proposed API

<SfModal cross="true/false">
<!-- default slot content -->
</SfModal>

cross is icon on top right corner and should just emit "close’ event.

There should be no content except “x”

Should be closable with ESC press and a11y-friendly

Check SfSidebar for body-locking logic.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:7 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
leomp12commented, Jun 11, 2019

@filrak right, even so I think SfModal may have overlay and persistent props, to be easier to use

1reaction
filrakcommented, Jun 11, 2019

@lorenaramonda @leomp12 Keep in mind that if we would like to use overlay it should be a separate component

Read more comments on GitHub >

github_iconTop Results From Across the Web

8 examples of great mobile modals that will delight ... - Appcues
Mobile modal windows or popups are a powerful tool for mobile app user engagement ... ways to use modal windows effectively in a...
Read more >
Creating Accessible HTML5 Modal Dialogs For Desktop and ...
In many cases, developers will implement focus state management for desktop devices, but not for mobile ones. You'd think you wouldn't need to ......
Read more >
The Optimal Way to Display Modals on Mobile Screens
A modal window on a desktop screen shouldn't look the same on a mobile one. ... modals in a window on mobile screens,...
Read more >
Any idea for Modal popup in Desktop view into New page in ...
So you will have to use media queries to re-adjust the width and height and the proportion of its contents on a mobile...
Read more >
Mobile-friendly Modal Window In Pure CSS - modal_box
... to create modal windows for both desktop and mobile devices. ... Mobile-friendly Modal Window In Pure CSS – modal_box ... How to...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found