Wrong prices after coupon code in cart/checkout

Current behavior

When entering a coupon code in checkout that has the setting in magento 2: “Deduct 5€ for whole cart” then the prices on the products are wrong:

Expected behavior

The price of the products in cart should not change if the coupon deducts from grand total… only if coupon is for product

Steps to reproduce the issue

Repository

Can you handle fixing this bug by yourself?

• YES
• NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

• This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
• This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
• This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

• Browser:
• OS:
• Node:
• Code Version: 1.11.4

Additional information

[Fifciu]

To close it, we need to merge:

• https://github.com/vuestorefront/vue-storefront/pull/5973/files
• https://github.com/vuestorefront/vsf-default/pull/63
• https://github.com/vuestorefront/vsf-capybara/pull/650

@lukaszjedrasik

[teuma86]

Just to further explain the fix as this theme is no longer available to review the code

<div class="prices" v-if="!displayItemDiscounts || !isOnline"> <span class="h4 serif cl-error price-special" v-if="product.special_price"> {{ product.price_incl_tax * product.qty | price(storeView) }} </span> <span class="h6 serif price-original" v-if="product.special_price"> {{ product.original_price_incl_tax * product.qty | price(storeView) }} </span> <span class="h4 serif price-regular" v-else data-testid="productPrice"> {{ (product.original_price_incl_tax ? product.original_price_incl_tax : product.price_incl_tax) * product.qty | price(storeView) }} </span> </div> <div class="prices" v-else-if="isOnline && product.totals"> <span class="h4 serif cl-error price-special" v-if="product.totals.discount_amount"> {{ product.totals.row_total - product.totals.discount_amount + product.totals.tax_amount | price(storeView) }} </span> <span class="h6 serif price-original" v-if="product.totals.discount_amount"> {{ product.totals.row_total_incl_tax | price(storeView) }} </span> <span class="h4 serif price-regular" v-if="!product.totals.discount_amount"> {{ product.totals.row_total_incl_tax | price(storeView) }} </span> </div> <div class="prices" v-else> <span class="h4 serif price-regular"> {{ (product.regular_price || product.price_incl_tax) * product.qty | price(storeView) }} </span> </div> </div>

Note displayItemDiscounts is a computed property which returns config.cart.displayItemDiscounts

If this is true, you will fall into the else-if section which uses product.totals.discount_amount

With Magento storing cart item discounts against the quote item as discount_amount. This results in the issue reported.

Thanks

Jamie