question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Bug Report][3.0.0-beta.1] VButton does not style `:disabled` correctly with color on variant="outlined"

See original GitHub issue

Environment

Vuetify Version: 3.0.0-beta.1 Vue Version: 3.2.36 Browsers: Chrome 101.0.4951.67 OS: Windows 10

Steps to reproduce

Expected Behavior

Disabled button should not have primary color

Actual Behavior

Disabled button styled with primary color

Reproduction Link

https://codepen.io/andrewspy/pen/dydZbgg

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:5 (2 by maintainers)

github_iconTop GitHub Comments

3reactions
zorn-vcommented, May 30, 2022

For variant that doesn’t color filled the button (such as outlined, and text), I would suggest it should always “grey” out instead of “color muted” as it doesn’t fit well with the overall contrast when disabled.

Agree, muted color is better only if button have bg color. If it “text” or “outlined” - grey is better.

2reactions
andrewspycommented, May 29, 2022

@KaelWD For variant that doesn’t color filled the button (such as outlined, and text), I would suggest it should always “grey” out instead of “color muted” as it doesn’t fit well with the overall contrast when disabled.

While using <v-btn :disabled="isDisabled" :color="isDisabled ? '' : 'regularColor'"> is possible, it does impact the DX as we are introducing additional computed isDisabled.

Just my opinion.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Custom style for disabled button applies to regular button also
Ok, I renamed the styles const, and wrapped the component using withStyles. It still does not work though. I think I'm not targeting...
Read more >
Buttons - Bootstrap
Use Bootstrap's custom button styles for actions in forms, dialogs, and more with support for multiple sizes, states, and more.
Read more >
Frustrating Design Patterns: Disabled Buttons
Imagine a world in which every button is disabled by default. Usually it's grey, subtle and slightly out of focus, often with poor...
Read more >
Building a button component - web.dev
In this post I want to share my thoughts on how to build a color-adaptive, responsive, and accessible <button> element.
Read more >
variant-classnames - npm
There are no other projects in the npm registry using ... Provided with <Button size="small" color="blue" disabled /> , the following CSS ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found