Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Automatic package release should start from the state of the repo that was reviewed

See original GitHub issue

as discussed in #144, there is a risk that the diff being reviewed in the PR that bumps the package version no longer match the state of the repo when that PR is merged.

The GH action that does the release should start from the state of the repo at the time of the diff.

We could for instance tag the repo as pre-x.y.z when generating the diff, and use that tag for the checkout in the release action.

Issue Analytics

State:
Created 3 years ago
Comments:9 (7 by maintainers)

Top GitHub Comments

1reaction

saschanazcommented, Mar 25, 2021

Where is that setting? Is it the “Require linear history” branch protection rule?

It’s below ~~that rule~~"Require status checks to pass before merging", if you check it then it will appear.

0reactions

tidoustcommented, May 31, 2021

One remaining bug tracked in #244, and a few possible improvements tracked in #226, #232, #237 but new workflows are now in place and documented in the README. New workflows guarantee that the package released is the package that was reviewed.

Closing this issue accordingly.

Top Results From Across the Web

Repo Command Reference | Android Open Source Project

Installs Repo in the current directory. This creates a .repo/ directory with Git repositories for the Repo source code and the standard Android ......

Repository checks - GitLab Documentation

Manually trigger this check for a project, using the GitLab UI. Schedule this check to run automatically for all projects. Run this check...

Git branch policies and settings - Azure Repos - Microsoft Learn

To manage branch policies, select Repos > Branches to open the Branches page in the web portal. Screenshot that shows the Branches menu...

Chapter 21 Git Version Control | Bioconductor Packages

During the review process you will likely need to update your package. Do this in your local repository by first making sure your...

GitHub Integration (Heroku GitHub Deploys)

After you link your Heroku app to a GitHub repo, ... When enabled, Heroku will only auto-deploy after all the commit statuses of...