What range of commits are looked at?

We have a private repo so I can’t share it with you. But we have two active branches going. Every Friday (or Monday) I merge from v4 to v5. Four weeks in a row this merge is failed due to the commitlint-github-action.

When I look at the details I see old commit messages that are not included in the current PR that are failing.

I would expect it to just be examining the handful of commits that are from v4 that are new to v5 and not older commit messages that were committed prior to our use of commitlint.

What data could I provide to help debug this issue?

this is our job definition (run on pull request):

jobs:
  lint:
    name: Lint Commit Messages
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
        with:
          fetch-depth: 0
      - uses: wagoid/commitlint-github-action@v4

[hicksjacobp]

I believe for us, our solution is to exclude the target. Following the example from @michaelgwelch above, instead of git log --first-parent v4ish...v5ish, this would be more appropriate: git log --first-parent v4ish...v5ish ^v5ish (exclude everything reachable from the target branch).

I’m not sure if this change is applicable to all consumers of this action…mainly those that use feature/topic branches for development which I believe your action was originally intending for @wagoid. Off hand and without diving deeper git log or testing it, I don’t know if adding ^target to always be used would have any negative effects.

Maybe this action can support a more advanced configuration option for additional log arguments?

[michaelgwelch]

@wagoid Yeah, we can’t rebase as both v4 and v5 are “released”. So we can’t be changing history on v5 to incorporate v4 changes into it.

Sorry I didn’t get to this sooner with the repo. Putting it on my TODO for today.