Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Enforce JS style guide (again)

See original GitHub issue

As reported in https://groups.google.com/d/msg/wagtail-developers/MjNuJnhXJv4/cPZX5LhnBgAJ - it appears that JS linting was broken when #2275 was merged (npm run lint:js now only checks the client folder). We need to:

fix the task to run across the whole codebase
add it to the make lint task https://github.com/torchbox/wagtail/blob/master/Makefile#L18-L20
fix the inevitable style violations that have crept in since #1237
add it to our CI setup

Issue Analytics

State:
Created 7 years ago
Reactions:1
Comments:10 (10 by maintainers)

Top GitHub Comments

1reaction

lb-commented, Apr 24, 2019

@thibaudcolas - makes sense.

Hopefully this will become a bit easier when all code is moved to the webpack build process (client folder)

cc @jonnyscholes

0reactions

lb-commented, Jan 15, 2022

thanks @thibaudcolas

Top Results From Across the Web

Google JavaScript Style Guide

1 Introduction. This document serves as the complete definition of Google's coding standards for source code in the JavaScript programming language.

ESLint: Everything You need to know about setting up a style ...

Again choose according to your need, it is asking these question because, ... Canonical is the most comprehensive code style guide.

JavaScript Standard Style

JavaScript style guide, linter, and formatter. This module saves you (and others!) time in three ways ... Never give style feedback on a...

Coding Style - The Modern JavaScript Tutorial

A style guide contains general rules about “how to write” code, e.g. which quotes to use, how many spaces to indent, the maximal...

JavaScript Style Guides And Beautifiers - AddyOsmani.com

Following a consistent style guide both helps enforce this concept and improves the overall quality of the code we write. This facilitates other ......