Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Include requestor IP in preview dummy_request?

See original GitHub issue

When wagtailcore.models.Page.dummy_request issues a dummy WSGIRequest to compute preview content, should it defensively include a reasonable REMOTE_ADDR header in case there are middleware installed which expect an IP address? Or should middleware always defensively handle the case where no requestor IP is provided?

I think it’s the responsibility of the middleware library to be defensive in this case, but curious if any Wagtail devs think it’s worth including a valid REMOTE_ADDR in the request.

Issue Analytics

State:
Created 8 years ago
Comments:5 (1 by maintainers)

Top GitHub Comments

1reaction

steragocommented, Sep 22, 2015

I have noticed that the missing REMOTE_ADDR header in the dummy request also causes an issue with django’s debug context processor, as it relies on this value to determine whether or not it should expose the debug context variable to the templates: https://github.com/django/django/blob/5153a3bfdcec82324d67ff79862384288cf6afe6/django/template/context_processors.py#L41

so adding REMOTE_ADDR to the dummy request should fix this issue as well.

0reactions

gasmancommented, Jul 6, 2016

Implemented in #2550.