Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Recommend & add official support for django-sendfile2 in place of django-sendfile (custom serve methods)

See original GitHub issue

Is your proposal related to a problem?

Describe the solution you’d like

  1. Unit test updates - current unit tests explicitly include django-sendfile to support the documented approach it seems, plus probably a bit of a pre 1.0 legacy
  2. Documentation updates - documentation advises using django-sendfile when it is probably better to support the more maintained django-sendfile2, it should be directly compatible but this change should come after the unit test changes (or in the same PR)
  3. Potentially replace utils/sendfile with an optional import of django-sendfile2 if needed (which is a copy of an even older version of the django-sendfile code)

Describe alternatives you’ve considered

  • Do nothing, the current solution of a copy of django-sendfile mostly works but has some issues and will likely break in future Django versions.

Additional context

Issue Analytics

  • State:open
  • Created 2 years ago
  • Comments:14 (14 by maintainers)

github_iconTop GitHub Comments

lb-commented, May 5, 2022

Removing ‘good first issue’ label as this will likely be a solid amount of work and require someone with knowledge of custom serve methods and django-sendfile to understand.

lb-commented, May 5, 2022

@spapas please review the updated description and confirm this covers what you are expecting.

Note that the issue templates really do help when requesting enhancements.

Read more comments on GitHub >

github_iconTop Results From Across the Web

List of scanned packages - SourceCode.AI
... adaptivepele adb-wifi adcircpy adcpy adct add-fraction addons addpack addpio ... avro-schema avro-service-clients avro-to-python avro-validator avro3k ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Post

No results found

github_iconTop Related Hashnode Post

No results found