question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Refactor UI components

See original GitHub issue

After #4979 is merged, we will refactor components to use BEM and ITCSS. Talk to me (@nmorduch, naomi on the Wagtail slack) if you’re interested in being a part of this effort!

Child issues can be found at the UI overhaul component label and corresponding Project. The child issues are just based on which scss files were in the components folder after rearranging the SCSS. Some may not need any work, and we may need to add more issues.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:17 (14 by maintainers)

github_iconTop GitHub Comments

2reactions
lb-commented, Apr 22, 2019

@thibaudcolas - I have recently worked through a revisit of our stylelint configs with a project I am working on. I think it is a great idea to separate out our ideal (most strict) config into its own repo, and then progressively use it across the scss as we work on it.

Stylelint Packages:

Styelint Config: I had a look through our existing config, it looks pretty good, I think some rules may need to be re-checked that they are available still.

It would be good to extend the stylelint-config-standard as it is a good set of configs to start with - https://github.com/stylelint/stylelint-config-standard/blob/master/index.js

Stylelint Tooling:

  • We have used Prettier Stylelint it is a CLI that runs stylelint fix and then prettier over the top, it helps to easily enforce many of the stylelint rules in an automated way (it makes the properties ordering practical to use).
  • Stylelint and prettier can work well together, they do different roles and I think we should use both for our scss files.
2reactions
lb-commented, Jan 30, 2019

@nmorduch I would love to pick up one or two of the scss refactor tickets over the coming weeks, I will keep an eye on this issue.

I have not done BEM but very keen to use it, it seems to make a lot of sense and really love the ITCSS structure!

Read more comments on GitHub >

github_iconTop Results From Across the Web

Refactoring UI
Refactoring UI takes everything we know about design and bundles it into one comprehensive package, including a book, screencasts, a component gallery, ...
Read more >
Refactoring UI: Transistor - YouTube
For this edition of Refactoring UI, we take a look at Transistors's integration page, sharing lots of tips on layout and form design....
Read more >
Refactoring UI: an essential guide | by Ahlam - Bootcamp
Refactoring UI : an essential guide. “Order and simplification are the first steps toward the mastery of a subject” Thomas ...
Read more >
Is "Refactoring UI" worth the money? - Alex Sidorenko
The main value of Refactoring UI is in a PDF book. If you just want the book, buy the Essentials. If you have...
Read more >
Refactoring designs, themes, templates and ... - Dribbble
Refactoring. Inspirational designs, illustrations, and graphic elements from the world's best designers. Want more inspiration? Browse our search results.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found