question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Using specific pages in pages index even when not paginating

See original GitHub issue

I’m referencing to those lines: https://github.com/wagtail/wagtail/blob/master/wagtail/wagtailadmin/views/pages.py#L85-L89

I’m using pages which override get_url_parts and would really like to have them during the ordering as well (for the live button for example).

Did you have a case when you really had performance issue? Is this optimisation really needed at the cost of loosing the actual behaviour of the pages?

Thanks

Issue Analytics

  • State:open
  • Created 7 years ago
  • Comments:9 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
gasmancommented, Apr 10, 2017

Happy to apply this change once #3355 is merged.

0reactions
Gagarocommented, Mar 7, 2017

I ran them again 30 times with a SingleEventPage (which have a different url):

Without specific:

time min: 20.10587787628174 max: 31.868613719940186 avg: 22.528464976946513
memory min: 99748051 max: 100280583 avg: 100091554.53333333

With specific:

time min: 21.079307079315186 max: 26.820695161819458 avg: 23.083278719584147
memory min: 98609968 max: 99143636 avg: 98941710.26666667
Read more comments on GitHub >

github_iconTop Results From Across the Web

Paginated Content – To Index or Not to Index
In the latest Google Webmaster Central office-hours hangout, John Mueller answered some questions on indexation of paginated content.
Read more >
Paginated Pages: A Complete Best Practices Guide - SEOquake
If web pages are not indexed for a while, search bots will receive a signal to stop crawling their content.
Read more >
Pagination Best Practices for Google | Documentation
Learn best practices for indexing your ecommerce site when using pagination and incremental page loading and how this can impact Google Search.
Read more >
Explore What Pagination Is and How to Implement It Properly
Explore what pagination is and how it is implemented on different websites. Check a specific URL on correct pagination tags.
Read more >
Page index gets set to -1 with manual pagination and ... - GitHub
Describe the bug When using manual pagination, if we have zero pages of results, any attempt to set the pageIndex gives a pageIndex...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found