Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Use proto library that provides tree-shakeable code

See original GitHub issue

Problem

ts-proto generate code that is not tree-shakeable. See https://github.com/status-im/status-web/issues/233

This is an issue as it inflate the package size for library consumers.

It also uses Buffer.

Solution

Possibly investigate using ipfs/protons or protobuf-js directly.

Definition of Done

New library that generate tree-shakeable code is used
Definition from https://github.com/vacp2p/waku are used

Bonus

js-waku currently uses bufbuild and ts-proto which has several downsides:

bufbuild is a separate binary that has to be installed
ts-proto generates code that uses Buffer It also has pros:
Generated code is TypeScript
Generates from proto files

Review whether we can use the solution for the examples in js-waku too.

Issue Analytics

State:
Created 2 years ago
Reactions:1
Comments:5 (2 by maintainers)

Top GitHub Comments

1reaction

D4ntecommented, Apr 1, 2022

Maintenance has been resumed 🎉 https://github.com/ipfs/protons/commit/74d3b7abf1e857f7320c100734e797855ea728c1

Focusing this issue in the tree-shakeable problem.

1reaction

prichodkocommented, Mar 2, 2022

I’ve also detected that generated files are not tree-shakeable, leaving a lot of unused code in the final bundle. See more: https://github.com/status-im/status-web/issues/233. I will investigate, whether there are some possibilities to optimize.