Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

session callback change

See original GitHub issue

follow up to #13 that introduced transportStatus and made the inconsistent callback even more inconsistent:


    interface Callback {
        fun transportStatus(status: Transport.Status)

        fun handleMethodCall(call: MethodCall)

        fun sessionApproved()

        fun sessionClosed()
    }

I suggest either add handleXX everywhere or remove it for handleMethodCall might go even further here (and reason this is an issue and not a PR) we could reduce to 2 methods: handleStaus and handleMethodCall and the session open closed events then come via the status

Issue Analytics

State:
Created 4 years ago
Comments:13 (1 by maintainers)

Top GitHub Comments

1reaction

ligicommented, Jul 19, 2019

Yes we can do - but would love 15 more minutes as I am testing around with it currently a bit more. If you need it earlier - feel free to tag

0reactions

pedrouidcommented, Jul 23, 2019

Hey @ligi, what is the weird behavior that you’re seeing with kotlin lib? There were changes with the Bridge server last week. Most notably, the ping opcode which wasn’t present before and the socket messages now include a boolean parameter called silent. Do any of these seem to be the cause of it?