signature never resolves on session already existing. [ethereum-provider 1.5.2]
See original GitHub issueI just did the switch from web3-provider to ethereum-provider. It brought a few issues with it, one of which is that signing does not resolve after the first signature.
To reproduce: Create an instance as usual and signin via QR code and call a signature; eg:
await provider.enable()
signature = await provider.request({ method: 'personal_sign', params: ['hellooooo', app.provider.accounts[0]], jsonrpc: '2.0' })
The first time, this works totally fine, the QR code and signature fully resolves one after the other.
However, if you call this one more time, or after a refresh
await provider.request({ method: 'personal_sign', params: ['hellooooo', app.provider.accounts[0]], jsonrpc: '2.0' })
the signature will pop-up on your phone, but never resolve on the client side.
I’m using metamask mobile as a phone wallet @walletConnect/ethereum-provider 1.5.2
Edit: I have updated @walletConnect/ethereum-provider
to 1.6.1.
Now if I don’t refresh after setting the provider and call
await provider.request({ method: 'personal_sign', params: ['hellooooo', app.provider.accounts[0]], jsonrpc: '2.0' })
it will result in a successful signature that will resolve.
HOWEVER the issue is still the same after refreshing the page (even though the provider is defined after refresh).
Issue Analytics
- State:
- Created 2 years ago
- Reactions:6
- Comments:8 (1 by maintainers)
Top GitHub Comments
bump @pedrouid ; Sorry for the tag but it seems it’s a relatively widespread issue;
@haowang1013 @Shmoji is this still an issue?