error when trying to load the @walletconnect/web3-provider lib in an iframe

I’m building a dApp which uses the @walletconnect/web3-provider lib indirectly. Locally and during testing everything works great, the issue comes when I deploy the app as it gets executed in an iframe:

main.js:formatted:134093 Uncaught DOMException: Failed to read the 'localStorage' property from 'Window': Access is denied for this document.

I traced back the exception to the storage utility class of this monorepo.

I believe the problem comes from this part:

export function unsafeGetFromWindow<T>(name: string): T | undefined {
  let res: T | undefined = undefined;
  if (typeof window !== "undefined" && typeof window[name] !== "undefined") {
    res = window[name];
  }
  return res;
}

As that is compiled down to:

"undefined" != typeof window && void 0 !== window.localStorage && (a = window.localStorage),

Which ends up throwing the exception.

[joshstevens19]

Safari blocks storing anything in local storage within an iframe. web3 use to use local storage without try catching it and this did not allow you to be able to use web3 in an iframe supporting every browser. A try-catch will solve this but if the lib needs local storage it should probably look into the new storage API which safari now supports - https://developer.mozilla.org/en-US/docs/Web/API/Storage_Access_API to allow this to support iframes in safari (which quite a lot of wallet integrations would be using to add protection between cross-site domains and holding the private key in memory without the integrator being able to get to it).

[finessevanes]

Hey @ramirotw, @wswarren12 are either one of you still experiencing this issue?