question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Perform EIP-712 typed data checks

See original GitHub issue

Implement eth_signTypedData from EIP-712 latest spec

Currently the SDK allows for arbitrary parameters. We should use uport’s eth-typed-data library to parse and format the typed data parameters correctly before sending to the wallet.

eth-typed-data: https://www.npmjs.com/package/eth-typed-data

Issue Analytics

  • State:open
  • Created 4 years ago
  • Reactions:2
  • Comments:6 (1 by maintainers)

github_iconTop GitHub Comments

3reactions
BrendanChoucommented, Aug 20, 2019

Please make sure to also support arrays which are in the latest spec of EIP-712

2reactions
BrendanChoucommented, Mar 25, 2020

Every wallet implements it differently so it’s pretty annoying, but this might help: https://github.com/dydxprotocol/solo/blob/d4a984499851adf1e8ab21f9408892aa8bc5fd63/src/modules/Signer.ts#L44

Read more comments on GitHub >

github_iconTop Results From Across the Web

EIP712 is here: What to expect and how to use it | MetaMask
Ethereum wallets like MetaMask will soon introduce the EIP712 standard for typed message signing. This standard allows wallets to display data in signing ......
Read more >
EIP-712: Typed structured data hashing and signing
A procedure for hashing and signing of typed structured data as opposed to just bytestrings.
Read more >
EIP-712: Signing and Verifying Typed Ethereum messages
This is necesssary because Metamask places a strict check on the network ID specified in the data message object sent to eth_signTypedData ....
Read more >
EIP-712 - YouTube
This Video explains EIP-712 in a plain and simple way. ... Your browser can't play this video. Learn more. Switch camera.
Read more >
Ethereum EIP712 Signature 2021
The Ethereum EIP 712 signature suite 2021 MUST be used in conjunction with the signing and verification algorithms in the Data Integrity ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found