React Native Sign SDK
See original GitHub issueDescription
Uppon testing sign SDK versions beta.102, rc.0 and rc.1 in latest react-native version (fresh vanilla app), all of these came up with errors like new TextEncoder()
being undefined. This happens in both jsc and hermes runtimes and will only get worse as react-native is moving towards preferring hermes. This issue can be solved in 2 ways i.e. heavy js polyfilling or we create @walletconnect/react-native-sign sdk that utalises Swift and Kotlin SDK’s. Latter is preferred way and will result in multiple benefits for react-native users i.e. logic will run on native thread and utilize native methods for storage / networking etc. This however needs a bit of research to understand if we can successfully implement Swift and Kotlin SDKs under one nice react-native js api similar to that of js package.
Tasks
- Create test sdk package that exposes Kotlin sdk and test against it
- If task no.1 is successful, continue with Swift sdk implementation
- If task no.1 fails, continue with js sdk polyfilling
Issue Analytics
- State:
- Created a year ago
- Comments:11 (4 by maintainers)
Top GitHub Comments
@IljaDaderko It appears to be working well! I will continue to test, but initially everything is looking good.
@matthewcarlreetz @nomanaliakram321 could you try following new installation docs for
2.0.0-rc.2
(preview) https://docs.walletconnect.com/2.0/javascript/guides/react-nativeIt should resolve all your issues and not require any custom polyfills.
Example react-native app with new react-native implementation is also available here https://github.com/WalletConnect/react-native-sign/tree/js-sdk/example