Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Restore doesn't work well

See original GitHub issue

Describe the Bug

Hi,

I Save my flow before to update the nodes/edges (remove/add some edges and nodes) and on pane Click I restore the original flow.

after the restore the positions of nodes and edges is not well restored. when the page is resized, the edges and nodes don’t seems to fit the view. The smooth edge looks curved a little bit to connect to the fixed node’s position.

Your Example Website or App

here below the code note that I’m using dagree for the layouting part

const nodeTypes: NodeTypes = {
  customNode: CustomNode,
};

const edgeTypes: EdgeTypes = {
  customEdge: CustomEdge
};

const flowKey = 'example-flow';

const SaveRestoreComponent = (props) => {
  const [reactflowInstance, setReactflowInstance] = useState<ReactFlowInstance>(null);
  const [nodes, setNodes, onNodesChange] = useNodesState<>([]);
  const [edges, setEdges, onEdgesChange] = useEdgesState<>([]);
  const { setViewport } = useReactFlow();

  const handleResize = useCallback(() => {
    reactflowInstance && reactflowInstance.fitView();
  }, [reactflowInstance]);

  const onSave = useCallback(() => {
    if (reactflowInstance) {
      const flow = reactflowInstance.toObject();
      localStorage.setItem(flowKey, JSON.stringify(flow));
    }
  }, [reactflowInstance]);

  const onInit = useCallback(
    (flowInstance: ReactFlowInstance) => {

      setNodes([...props.nodes]);
      setEdges([...props.edges]);

      if (!reactflowInstance) {
        setReactflowInstance(flowInstance);
      }
    },
    [props.nodes, props.edges, setNodes, setEdges, reactflowInstance]
  );

  const onRestore = useCallback(() => {
    const restoreFlow = async () => {
 
      const flow = JSON.parse(localStorage.getItem(flowKey));

      if (flow) {
        const { x = 0, y = 0, zoom = 1 } = flow.viewport;
        setNodes(flow.nodes || []);
        setEdges(flow.edges || []);
        setViewport({ x, y, zoom });

        updateElements(flow.nodes, flow.edges);
      }
    };

    restoreFlow();
  }, [setEdges, setNodes, setViewport]);

  const onNodeClick = useCallback((event: React.MouseEvent, node) => {

     onSave();
     const {nodes, edges} = updateFlow(node);
     setNodes([...nodes]);
     setEdges([...edges]);
    
    },[onSave, setEdges, setNodes]
  );

  const onPaneClick = useCallback(
    (event: React.MouseEvent) => {
        onRestore();
    },
    [onRestore]
  );

  useEffect(() => {
    window.addEventListener('resize', handleResize);
    reactflowInstance && reactflowInstance.fitView();
    return () => window.removeEventListener('resize', handleResize);
  }, [handleResize, reactflowInstance]);

  return (
    <ReactFlow
      nodes={nodes}
      edges={edges}
      nodeTypes={nodeTypes}
      edgeTypes={edgeTypes}
      onNodeClick={onNodeClick}
      onPaneClick={onPaneClick}
      onInit={onInit}
      onNodesChange={onNodesChange}
      onEdgesChange={onEdgesChange}
      minZoom={1}
      fitView
    ></ReactFlow>
  );
});

export const Flow = (props) => {
  return (
    <ReactFlowProvider>
      <SaveRestoreComponent {...props} />
    </ReactFlowProvider>
  );
};