Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Stress test performance

See original GitHub issue

Hi! I’ve noticed that stress test performance in the examples is quite poor (10x10 is really not a very big graph). I think it could be fixed with these improvements:

batch updateNodeDimensions calls on initial render (this seems to be a bottleneck)
render only nodes in view (given that they already use ResizeObserver, it shouldn’t be too hard)

I’ve already done the same performance patch for https://github.com/MrBlenny/react-flow-chart a while ago (https://github.com/MrBlenny/react-flow-chart/pull/7), if you are interested, I can try to make a similar PR for this project (I hope this one will have a better maintenance in future)

Issue Analytics

State:
Created 3 years ago
Reactions:1
Comments:33 (15 by maintainers)

Top GitHub Comments

2reactions

moklickcommented, Feb 10, 2021

We wanted to do a next version without or at least with few as possible breaking changes. Since easy-peasy uses redux we only have to make a few adjustments and the api can stay the same. Maybe for v10.0.0 we could think about using recoil or something similar.

2reactions

moklickcommented, Dec 10, 2020

The codesandbox seems to be the default codesandbox.

Since react flow is not canvas/webgl based it’s meant to be used for smaller/midsize flows. Everything above a few hundred nodes (depending how complex the nodes are) will be hard to handle I guess.