Use linter exit code to determine check result

I tried out the rubocop linter in my project and I noticed that when I have warnings:

I still get a green check:

That’s not the way that the typical rubocop setup works, usually those errors would return a non-zero exit code and fail the build. I wouldn’t even know I needed to look for errors unless I click into the Detail screen.

I noticed that here you’re only considering errors in the Check status: https://github.com/samuelmeuli/lint-action/blob/a838ab16415bb1752bb9d77b4ce13fa80bfcaef6/src/github.js#L75

Would you consider failing on warnings as well? Or make that configurable?

[larsklevan]

Thank you for the quick fix! I tried it with rubocop in my project and it’s working great.

[larsklevan]

It probably makes sense to use the linter’s exit code to determine the check conclusion

I like this approach. Seems like it would be consistent with the way CI typically works.