question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Unable to select any hours before noon when TimePickerModal is in 24-hour clock mode

See original GitHub issue

I’m unable to select any hour before noon when TimePickerModal is in 24-hour clock mode (e.g. locale is de). Only hours after 12 noon can be selected. Issue can be reproduced by changing the locale prop to “de” in the Time picker sample code:

<TimePickerModal
   visible={visible}
   onDismiss={onDismiss}
   onConfirm={onConfirm}
   hours={12} // default: current hours
   minutes={14} // default: current minutes
   label="Select time" // optional, default 'Select time'
   uppercase={false} // optional, default is true
   cancelLabel="Cancel" // optional, default: 'Cancel'
   confirmLabel="Ok" // optional, default: 'Ok'
   animationType="fade" // optional, default is 'none'
   locale="de"
/>

I’ve tested this with release 0.8.4 on iOS and web.

Simulator Screen Recording - iPhone 11 - 2022-01-13 at 15 53 06

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:10 (7 by maintainers)

github_iconTop GitHub Comments

3reactions
J3j3mcommented, Jan 19, 2022

I got the point, i’m working on a fix that will not break Am/Pm mode

2reactions
J3j3mcommented, Jan 21, 2022

PR Submitted, have a good week-end 🙌

Read more comments on GitHub >

github_iconTop Results From Across the Web

TimePicker doesn't allow "24:00"? - Stack Overflow
In 24 hour mode, the TimePicker should really allow 24:00 to be entered. The 24-hour clock system in ISO 8601 defines midnight as...
Read more >
<input type="time"> - HTML: HyperText Markup Language | MDN
<input> elements of type time create input fields designed to let the user easily enter a time (hours and minutes, and optionally seconds)....
Read more >
[Bug] [UWP] Format property of TimePicker not respected on ...
Description I am attempting to get a TimePicker on UWP to display a time in the format "09:49" aka 24 hour time. All...
Read more >
Android Time Picker - Xamarin - Microsoft Learn
TimePicker allows users to select the time of day in either 24-hour or 12-hour AM/PM mode. TimePickerDialog is a helper class that ...
Read more >
How to Display a TimePicker in Angular - Step by Step
This short tutorial explains how to display step by step a TimePicker on an Angular Form. All Angular + SpringBoot ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found