findExecutableOnPath, for the new webp feature, can cause NPE in some environments
See original GitHub issueIssue Description:
Commit 460e6f981 of 2020-10-25 adds a new method findExecutableOnPath
that calls System.getenv("PATH").split ...
. In a Multicraft environment, java seems to get called without PATH
being defined, probably for security reasons. This results in System.getenv("PATH")
returning null
, and the method throwing a NPE, preventing dynmap initialization.
Solution: make the method return null if System.getenv("PATH")
returns null.
[X] I have looked at all other issues and this is not a duplicate
[X] I have been able to replicate this
Issue Analytics
- State:
- Created 3 years ago
- Reactions:1
- Comments:13
Top Results From Across the Web
Frequently Asked Questions | WebP - Google Developers
WebP is a method of lossy and lossless compression that can be used on a large variety of photographic, translucent and graphical images...
Read more >WebP image format | Can I use... Support tables for ... - CanIUse
Image format (based on the VP8 video format) that supports lossy and lossless compression, as well as animation and alpha transparency. WebP generally...
Read more >Enabling WebP by default – Make WordPress Core
With this new feature, users can continue uploading and using the same JPEG images they do today and behind the scenes WordPress will...
Read more >How To Create and Serve WebP Images to Speed Up Your ...
In this tutorial, you will use the command-line tool cwebp to convert images to WebP format, creating scripts that will watch and convert...
Read more >Work with WebP files in Photoshop - Adobe Support
You can easily save your 8-bit RGB Photoshop documents in the WebP file format. WebP format provides both lossless and lossy compression for ......
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Don’t be so hard on the author, he has been supporting dynmap for many years, even added support for Forge and Fabric recently, and dedicated a lot of time into the project - time he isn’t getting paid for. None of us knows how the pandemic affects him or his family, and if he has other priorities right now, then noone has the right to critizise this.
Also, releasing a piece of software correctly is much more work than just uploading it; you need to run tests, upload to all distribution sites, update descriptions, update version info, and even if some of this can be automated, you still need to do a lot of work manually.
I’m convinced that, when once one development speeds up again, this fix will quickly make it into the official distribution. Until then, enjoy the advantage of open source which means people can fix stuff themselves if the original author won’t, for whichever reason.
I didn’t intend to publish my version, because, as I said, software from unknown origins isn’t what people should run. But, it’s been over two weeks without this bug being resolved, so, here’s my release:
https://github.com/gbl/dynmap/releases/tag/fix_path_problem
Note that I wrote that before dynmap officially supported 1.16.4, so, it was forked from an older version. But it has been in production on two different servers for two weeks now, so it should work for you as well.