isAsyncChunkPushExpression is checking for left side which cannot be easily determined

Issue description

https://github.com/webpack-contrib/webpack-bundle-analyzer/blob/757c12e03b8260b3428db1c618224a90b69569c1/src/parseUtils.js#L191-L214

These lines https://github.com/webpack-contrib/webpack-bundle-analyzer/blob/757c12e03b8260b3428db1c618224a90b69569c1/src/parseUtils.js#L201-L208

Are checking if .push is called on window, self or this. So for the simple cases:

window.webpackJsonp_someCustomName = (window.webpackJsonp_someCustomName || []).push(...)

it works well.

But sometimes Webpack creates left side output which can be MemberExpression:

(("undefined" != typeof self ? self : this).webpackJsonp_someCustomName = ("undefined" != typeof self ? self : this).webpackJsonp_someCustomName || []).push(...);

I am thinking is there any need for checking of the left side? We are already checking a lot of things and

mayBeAsyncChunkArguments(args[0].elements) && isModulesList(args[0].elements[1])

should make us confident that it is indeed a module.

[Gongreg]

For me from the history seems like it was simply added while working on chunks, and then more different scenarios were found and added on top as additional checks. So most likely left side can be skipped. I will make a pr without it.

[valscion]

I don’t really know why we need to be so strict in checking the left-hand side here. Maybe if all the tests pass with the left-side check being more relaxed or removed altogether is good enough?

Does @th0r have any insight on why the left-hand side expression check has been there?