BuildDependencies in cache not update

Bug report

What is the current behavior? I’m using webpack to bundle my project, if BuildDependencies in cache configuration is updated but the cache pack is not invalid, the pack will not updated.

If the current behavior is a bug, please provide the steps to reproduce. Use this repo: https://github.com/killagu/webpack-cache-bug/

1. Run npm run build
2. Run npm run build2

The cache will not update.

What is the expected behavior? Update the cache to ensure all BuildDependencies will be checked in next bundle.

Other relevant information: webpack version: 5.48.0 Node.js version: v14.16.0 Operating System: MacOS Additional tools:

How to fix it?

// https://github.com/webpack/webpack/blob/main/lib/cache/PackFileCacheStrategy.js#L1116
- if (!pack.invalid) return;
this.logger.log(`Storing pack...`);
let promise;
const newBuildDependencies = new Set();
for (const dep of this.newBuildDependencies) {
	if (!this.buildDependencies.has(dep)) {
		newBuildDependencies.add(dep);
	}
}
+ if (!pack.invalid && !newBuildDependencies.size) return;

If it’s right, I’m glad to fix it.

[alexander-akait]

Anyway let’s mark it as enhancement

[sokra]

Deleting build dependencies is not valid. They have to stay in the cache, since cache entries have been created with these build dependencies.