Detect getters and setters

Rule request

Thesis

We can inspect class and instance methods to find these pattern: if class contains two methods like get_X and set_X we should raise UnpythonicGetterSetterViolation

We should also detect cases like:

• class has instance or class level attribute x or _x or __x
• class has method called get_x or set_x

It is oop violation.

Reasoning

Because python does not need this abstraction:

• Either use @property
• Or just make the property public and change it

[sobolevn]

Yes 👍

[sobolevn]

Sorry, that I am not able to express myself clear enough 🙂

This rule only checks method names. We need to detect patterns like get_${existing_attribute_name} and set_${existing_attribute_name} and raise violations when any of these methods are found.

Where ${existing_attribute_name} can be public, protected, or private name of instance or class level attribute.