False positive DirectMagicAttributeAccessViolation with __subclasses__

Bug report

What’s wrong

class MyClass(object):
    """My class."""

subs = MyClass.__subclasses__()

This piece of code raises WPS609 Found direct magic attribute usage: __subclasses__

How is that should be

__subclasess__ method should be excluded from the check because it’s a class method and can be used outside of class.

Maybe there are other methods that should be excluded?

[sobolevn]

@AlwxSin submit a PR then 🛷

[sobolevn]

@mattany thanks a lot! And congrats on your first open-source fork 🎉

I am going to help you!

1. We need to find the violation that @AlwxSin is talking about. It can be done even inside Github’s search: https://github.com/wemake-services/wemake-python-styleguide/search?q=DirectMagicAttributeAccessViolation&unscoped_q=DirectMagicAttributeAccessViolation
2. Then we locate that it is used in four files: we are only interested in visitors. Read more about our architecture here: https://wemake-python-stylegui.de/en/latest/pages/api/index.html#overview
3. Then we find the exact place where this violation is raised in the visitor: https://github.com/wemake-services/wemake-python-styleguide/blob/58b96219a39390c35353aa9a29d483d5ed3f1cf7/wemake_python_styleguide/visitors/ast/attributes.py#L67

And let’s start from here: we can create a whitelist of method names that can be called. And do not raise violation if this method name is inside the whitelist.

Feel free to ask any questions!