Forbid `raise Exception`

Rule request

Thesis

Forbid to raise Exception or BaseException

# bad
raise Exception
raise Exception("user not found")
raise BaseException
raise BaseException("user not found")

# good
raise UserNotFoundError
raise UserNotFoundError("cannot find user with the given id")

Reasoning

Bare exception hard to catch and when you catch them you can suppress something else.

On Built-in Exceptions:

The built-in exceptions listed below can be generated by the interpreter or built-in functions…

User code can raise built-in exceptions. This can be used to test an exception handler or to report an error condition “just like” the situation in which the interpreter raises the same exception; but beware that there is nothing to prevent user code from raising an inappropriate error.

On User-defined Exceptions:

When creating a module that can raise several distinct errors, a common practice is to create a base class for exceptions defined by that module, and subclass that to create specific exception classes for different error conditions.

[hhsdev]

@orsinium @sobolevn Shouldn’t this be closed since the PR is merged?

[hhsdev]

@sobolevn Ah my bad, didn’t read the code thoroughly.