Forbid to use `&` and `|` with booleans

Rule request

Thesis

Yesterday I saw this code:

my_result = (first > 0 & second != 0) | other is None

And I was 😮

So, we need to check all operations around & and | and detect any booleans there:

• Explicit True and False
• Compares with is or == or !=
• Compares with >, >=, etc
• Logical operations not, or, and

If we can detect at least one of these operations, then we should raise a violation. Let’s call it BinaryAndBooleanMixupViolation.

Note: other binary operations are still fine! So, these lines should not raise:

• first & second
• first | 10
• etc

Reasoning

This case indicates that a person confused & with and and | with or. This can be the case if a person is comming from another language.

[thammaji]

Hi, I would like to try working on this issue. This would be my first issue, so I’m not sure of a solution yet as I’m still going through the contribution tutorials. I’ll update once I have an idea for a solution, but any suggestion is welcome too!

Also would calling & and | as bitwise operator be more appropriate? so the error would be BitwiseAndBooleanMixupViolation

[thammaji]

Oh I see. I will move my visitor to operators.py then (it fits there better anyway).