`get_*` functions must return something.

Rule request

Thesis

Functions and methods with get_ prefix must return something (have return or yield in the body).

Reasoning

get_ function is expected to return what it promises to return. For example, get_user returns a user object. If it’s not so, it’s an error or a bad interface.

[hhsdev]

@sobolevn Sorry to bother again.

The code is almost complete. But I wondered whether or not we should check every execution path a function can take to make sure it consistently returns a value .

Consider:

def get_foo():  # explicit return None; A-ok
    if some_condition:
        return 1
    return None

def get_bar():  # implicitly returns None if some_condition == False
    if some_condition:
        return 1

Should get_bar raise GetterWithoutReturnViolation?

[sobolevn]

@hhsdev we already have a different rule that checks for consistent returns. This rule should check that we have at least one non-empty return.