Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

WPS425 boolean non-keyword argument clashes with setdefault

See original GitHub issue

Bug report

What’s wrong

example_dict = {}
example_dict.setdefault("value", True)
>>> WPS425 Found boolean non-keyword argument

example_dict = {}
example_dict.setdefault("value", default=True)
>>> TypeError: setdefault() takes no keyword arguments

How is that should be

Not sure. Maybe there should be a whitelist of allowed methods/functions?

System information

Python 3.7.4

flake8 information

Contents of flake8 --bug-report:

flake info

  {
    "dependencies": [
      {
        "dependency": "entrypoints",
        "version": "0.3"
      }
    ],
    "platform": {
      "python_implementation": "CPython",
      "python_version": "3.7.4",
      "system": "Darwin"
    },
    "plugins": [
      {
        "is_local": false,
        "plugin": "flake8-annotations-complexity",
        "version": "0.0.2"
      },
      {
        "is_local": false,
        "plugin": "flake8-bandit",
        "version": "2.1.2"
      },
      {
        "is_local": false,
        "plugin": "flake8-blind-except",
        "version": "0.1.1"
      },
      {
        "is_local": false,
        "plugin": "flake8-broken-line",
        "version": "0.1.1"
      },
      {
        "is_local": false,
        "plugin": "flake8-bugbear",
        "version": "19.8.0"
      },
      {
        "is_local": false,
        "plugin": "flake8-comprehensions",
        "version": "3.1.4"
      },
      {
        "is_local": false,
        "plugin": "flake8-darglint",
        "version": "0.4.1"
      },
      {
        "is_local": false,
        "plugin": "flake8-debugger",
        "version": "3.2.1"
      },
      {
        "is_local": false,
        "plugin": "flake8-docstrings",
        "version": "1.5.0, pydocstyle: 5.0.1"
      },
      {
        "is_local": false,
        "plugin": "flake8-eradicate",
        "version": "0.2.3"
      },
      {
        "is_local": false,
        "plugin": "flake8-executable",
        "version": "2.0.3"
      },
      {
        "is_local": false,
        "plugin": "flake8-print",
        "version": "3.1.4"
      },
      {
        "is_local": false,
        "plugin": "flake8-return",
        "version": "0.1.3"
      },
      {
        "is_local": false,
        "plugin": "flake8-string-format",
        "version": "0.2.3"
      },
      {
        "is_local": false,
        "plugin": "flake8_builtins",
        "version": "1.4.1"
      },
      {
        "is_local": false,
        "plugin": "flake8_coding",
        "version": "1.3.2"
      },
      {
        "is_local": false,
        "plugin": "flake8_commas",
        "version": "2.0.0"
      },
      {
        "is_local": false,
        "plugin": "flake8_isort",
        "version": "2.3"
      },
      {
        "is_local": false,
        "plugin": "flake8_pep3101",
        "version": "1.2.1"
      },
      {
        "is_local": false,
        "plugin": "flake8_quotes",
        "version": "2.1.1"
      },
      {
        "is_local": false,
        "plugin": "logging-format",
        "version": "0.6.0"
      },
      {
        "is_local": false,
        "plugin": "mccabe",
        "version": "0.6.1"
      },
      {
        "is_local": false,
        "plugin": "naming",
        "version": "0.9.1"
      },
      {
        "is_local": false,
        "plugin": "pycodestyle",
        "version": "2.5.0"
      },
      {
        "is_local": false,
        "plugin": "pyflakes",
        "version": "2.1.1"
      },
      {
        "is_local": false,
        "plugin": "pylint",
        "version": "2.4.4"
      },
      {
        "is_local": false,
        "plugin": "radon",
        "version": "2.4.0"
      },
      {
        "is_local": false,
        "plugin": "rst-docstrings",
        "version": "0.0.12"
      },
      {
        "is_local": false,
        "plugin": "wemake-python-styleguide",
        "version": "0.13.2"
      }
    ],
    "version": "3.7.9"
  }

Related #1085

Issue Analytics

State:
Created 4 years ago
Comments:7 (5 by maintainers)

Top GitHub Comments

1reaction

sobolevncommented, Jan 24, 2020

We are going to allow one-argument booleans in the next release: https://github.com/wemake-services/wemake-python-styleguide/pull/1114

1reaction

sobolevncommented, Jan 16, 2020

The problem is that Python API is inconsistent as f. They actually had to create / params to fix it.

Why I don’t like to create any kind of whitelist here: it is really hard to cover all cases correctly. For example: one can have def setdefault(self, key, default): in their own class. And it would be a violation not to provide a keyword here. So, we cannot be sure when we are based on names, not types.

I am going to work on this soon enough, I have a working prototype of type inferring mechanism that works for our case.

Another option is to just turn off this check.