Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Breaking change with no class in quotations

See original GitHub issue

In previous versions you could set a class to empty for example we had several projects with initial : "", so that it wouldn’t add an initial class. With the new changes for multiple classes that throws an error and prevents headroom from running. We had done this as we didn’t want additional classes we didn’t need added to things.

Issue Analytics

State:
Created 4 years ago
Comments:7 (4 by maintainers)

Top GitHub Comments

1reaction

WickyNilliamscommented, Feb 21, 2020

I was going to ping you to ask your opinion @hacknug, since I saw you had commented on a previous issue. Interesting that you’ve changed your mind since.

I’m not averse to this idea in principle, but as I said it would require a fairly substantial rewrite of the internals. I plan to do this eventually, but not right now. I will come back to this then

0reactions

hacknugcommented, Feb 21, 2020

As one of the people who brought this up a couple years ago, today I wouldn’t bother adding support for it. Like @WickyNilliams said in https://github.com/WickyNilliams/headroom.js/issues/226#issuecomment-223307160, without any real performance issues, I don’t think it’s worth the effort.

So I would advise against this. It never did what you thought and I don’t want to support this use-case anyway. This is not just as a matter of taste, but because the internals of the library would make it difficult (it would require a pretty large reworking of how its state is managed)

If you wanna take a stab at it and open a PR, I’ll try to review and test the changes but again, please make sure it makes sense to spend time and resources into this.

As I mentioned before when it comes to classes being added I am a big fan ( as are these people ) of less is more. I work with Wordpress a lot and it just adds classes for fun it seems.

I agree with you but you need to keep in mind you should only remove useless stuff. The classes we’re talking about are used to keep track of the instance’s state (unlike WordPress which in my cases are useless 99% of the time).

It also seems like it would be pretty quick and easy to add support for this.

The creator of the library literally told you it would require to rewrite the whole state-management part of the library. Make sure you keep this in mind if you end up trying to change the way the library works 👍