Navigation refresh throws JsonReaderException

“Unexpected character encountered while parsing value: e. Path ‘’, line 0, position 0.”

I’m trying to refresh a view. Refreshing with no arguments gives me an empty view, but when passing the proper argument i get a JsonReaderException. The same object is fine when navigating to a new instance of the same view. The OnNavigatedToAsync is not reached before the exeption is thrown. Running on .net core version 5.2.2

var nav = WindowWrapper.Current().NavigationServices.FirstOrDefault();
//Throws exception
nav.Refresh(someObject);
//Works fine
nav.Navigate(typeof(Views.myView), someObject);

[tibitoth]

The problem is that the NavigationService.Refresh() method doesn’t serialize the given parameter, but the Navigate() does. https://github.com/Windows-XAML/Template10/blob/master/Template10 (Library)/Services/NavigationService/NavigationService.cs#L340 https://github.com/Windows-XAML/Template10/blob/master/Template10 (Library)/Services/NavigationService/NavigationService.cs#L211

Currently you need to serialize the parameter by hand like this:

NavigationService.Refresh(SerializationService.Json.Serialize(someObject));

I think we need to add serialization into the Refresh() too.

[JerryNixon]

That being said, I think Refresh(param) is a mistake.