[3.0.0-rc3] Logging object with circular references breaking

v3.0.0-rc3

When logging data with circular data, it does not log and subsequent logs are not logged neither

      const customData = {};
      customData.myself = customData; // circular data

      const logger = winston.createLogger({ transports: [new winston.transports.Console()] });
      logger.info('hello'); // shows on console

      logger.error({
        message: 'testing error',
        myCustomData: customData,
      }); // doesn't log

      logger.info('hello'); // doesn't log

[indexzero]

@crussell52 @Nokel81 @danlevan removing built-in, default always on support for logging of circular object references was a conscious performance decision for the default winston behavior in winston@3.

This problem is 100% solvable as a custom format – here’s a quick & dirty one. If you’d like to contribute one to logform (like circular-json or perhaps a { circular: true } option that users must opt-in to) that would be neat.

const cycle = require('cycle');
const { format } = require('winston');
const { combine, json } = format;

// Create a format to decycle the object
const decycleFormat = format((info, opts) => cycle.decycle(info))

// Combine the decycleFormat with the built-in json format.
const circularJsonFormat = combine(
  decycle(),
  json()
);

[crussell52]

… and subsequent logs are not logged neither

This may be arguable the more important point – I ran into a case where a formatter threw an exception and all subsequent log attempts quietly failed. An edge-case failure in logging a message should not halt all logging 😟

Is that expected behavior?