createLogger breaking changes under patch release

Please tell us about your environment:

• winston version?
  • [+] winston@3
• node -v outputs:
• Operating System? macOS
• Language? Typescript 3.5.3

What is the problem?

createLogger exported by winston, will now return Logger<winston.AbstractConfigSetLevels> which is a breaking change as before 3.3.0/3.3.1 release createLogger would return Logger.

What do you expect to happen instead?

Breaking change is introduced in a major version

Other information

n/a

[Mizumaki]

@DABH Sorry to commit code with some mistakes… 😭 @Pigotz Thanks for fixing it! 👍

@rossanmol Hmm, sorry but I can’t figure out what problem occurred. Do you face some concrete problems because of this change, or you wanna just mention this is breaking change? If you have some problem, can you explain it in detail?

In my environment, T extends Config.AbstractConfigSetLevels = DefaultLevels is enough and T extends Config.AbstractConfigSetLevels = DefaultLevels | Config.AbstractConfigSetLevels doesn’t make any difference. (because if you omit the generics, always DefaultLevels is set.)

Anyway, sorry to commit the breaking change in patch release. 🙇

[DABH]

@sigorilla , I’m waiting for the fixes/changes proposed by @AuHau @Mizumaki @rossanmol . Will give those folks a few hours – I will check back in a few hours and hopefully we can get a proper fix merged and released then. Thanks all.