Meta not included in logging of Error

Please tell us about your environment:

• winston version?
  • winston@2
  • winston@3
• node -v outputs: v11.6.0
• Operating System? macOS
• Language? all

What is the problem?

Using defaultMeta while logging a JS Error does not include the default meta values… e.g. in the .catch of a Promise

.catch(logger.error)

What do you expect to happen instead?

The attributes/values of defaultMeta should be included, but are not.

Other information

🐞 I believe there could be a bug somewhere around here. Maybe either this._addDefaultMeta(msg) or Object.assign({}, this.defaultMeta, ... is missing in some cases.

[peey]

In general you shouldn’t expect f(object.method) to work same as f(() => object.method())

You can see that at the following line, what you’re doing would break the this binding.

https://github.com/winstonjs/winston/blob/2625f60c5c85b8c4926c65e98a591f8b42e0db9a/lib/winston/logger.js#L645

Unless you explicitly use .bind, which the library authors may have done inconsistently in some places so it might work. But in general the responsibility lies with the library user and not the library to not break the binding.

[maverick1872]

I believe this to be a case of improperly using a catch clause on the Promise instance. For reference, this clause expects a function that it will then call in a rejection scenario. Since the original example is that of someone passing an Error instance as the function argument to catch, I’m considering this an invalid issue and will be closing it.