Pin dependency on `colors` package to version 1.4.0
See original GitHub issueWhat is the problem?
The NPM package colors
prints to the console in an infinite loop that leads to a crash for any version > 1.4.0.
See https://github.com/Marak/colors.js/issues/285 and https://www.bleepingcomputer.com/news/security/dev-corrupts-npm-libs-colors-and-faker-breaking-thousands-of-apps/
What do you expect to happen instead?
No infinite loop.
The dependency on colors
should be pinned to 1.4.0
exactly instead of:
https://github.com/winstonjs/winston/blob/65ab472f54906c72c6c72cffc0a12c9f1d0fe995/package.json#L46
Issue Analytics
- State:
- Created 2 years ago
- Reactions:5
- Comments:9 (4 by maintainers)
Top Results From Across the Web
Open source maintainer pulls the plug on npm packages ...
We highly recommend you revert to colors@1.4.0 , and pin your dependencies' versions to avoid blind upgrades of the offending version.
Read more >Open Source Developer Sabotages npm Packages 'Colors ...
The developer behind popular npm libraries "Colors" and "Faker" ... and prefer to pin your dependency versions and install plans.
Read more >How new version of NPM package "colors" broke ... - Reddit
The code itself doesn't depend on colors , but cli-table3 , which we had a pinned version of did depend on colors ,...
Read more >How should you pin dependencies and why? – The Guild
With the term pinning we are referring to the practice of making explicit the version of the libraries your application is depending on....
Read more >npm Libraries 'colors' and 'faker' Sabotaged in Protest by their ...
Popular npm open source libraries, colors.js, and faker.js were sabotaged ... to pin your dependency versions to a specific, trusted version ...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
No worries, I accept payment in GitHub follows or something 😅 v3.3.4 is out now which mitigates this. Hopefully doing it as a patch version gets this fix out to as many Winston users as possible asap. I’ll continue working with the appropriate folks for the next couple days about resolving the long-term stewardship of colors, but meanwhile, rest assured Winston is ok.
Also, add
to the package.json to prevent other dependencies from requiring them too.