Transports and v2 to v3 migration
See original GitHub issueHi 👋!
With the 3.0 release coming, I am trying to get a sense for what the expectation is for Transport authors to deal with the new release. We are getting feature requests for winston@3 support already on our transport.
Looking at the upgrade guide it seems like there are significant enough API changes that I don’t see an easy way to support both winston@2 and winston@3 out of the same transport package. Is the expectation that Transport
authors would be releasing a new set of packages for winston@3 (e.g. winston-funky-transport vs. winston3-funky-transport). Alternatively do we need to maintain two semver major branches concurrently on for winston@2 and one for winston@3? Both of those options sound unappetizing to me.
I can imagine some shenanigans where we try to require winston dynamically to see what the user actually has available and then expose a different version depending of the precise version? That is way too hacky, and something we can’t to do in our Transport – as we are a TypeScript project and want the users to have predictable usable types.
It is possible I am either overthinking it, or perhaps I am missing something. If the project authors here have thoughts on this, it would be great to have some feedback on what the vision about the Transport migration path is.
Thanks a lot!
Issue Analytics
- State:
- Created 5 years ago
- Reactions:3
- Comments:5 (3 by maintainers)
Top GitHub Comments
@vongohren, see this PR, explicitly for Winston@3. Could use help on the two failing test cases.
Is this going anywhere, particularly in regards to https://github.com/googleapis/nodejs-logging-winston/issues/84