question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Transports and v2 to v3 migration

See original GitHub issue

Hi 👋!

With the 3.0 release coming, I am trying to get a sense for what the expectation is for Transport authors to deal with the new release. We are getting feature requests for winston@3 support already on our transport.

Looking at the upgrade guide it seems like there are significant enough API changes that I don’t see an easy way to support both winston@2 and winston@3 out of the same transport package. Is the expectation that Transport authors would be releasing a new set of packages for winston@3 (e.g. winston-funky-transport vs. winston3-funky-transport). Alternatively do we need to maintain two semver major branches concurrently on for winston@2 and one for winston@3? Both of those options sound unappetizing to me.

I can imagine some shenanigans where we try to require winston dynamically to see what the user actually has available and then expose a different version depending of the precise version? That is way too hacky, and something we can’t to do in our Transport – as we are a TypeScript project and want the users to have predictable usable types.

It is possible I am either overthinking it, or perhaps I am missing something. If the project authors here have thoughts on this, it would be great to have some feedback on what the vision about the Transport migration path is.

Thanks a lot!

/cc @MylesBorins @DominicKramer

Issue Analytics

  • State:open
  • Created 5 years ago
  • Reactions:3
  • Comments:5 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
kazazescommented, Aug 24, 2018

@vongohren, see this PR, explicitly for Winston@3. Could use help on the two failing test cases.

1reaction
vongohrencommented, Aug 24, 2018

Is this going anywhere, particularly in regards to https://github.com/googleapis/nodejs-logging-winston/issues/84

Read more comments on GitHub >

github_iconTop Results From Across the Web

Can't migrate from V2 to V3 because the migrate app is not ...
I'm trying to migrate all my ABP end devices to V3, but there is a problem. The ttn-lw-migrate tool tells me: permission denied:...
Read more >
Migrate applications from using API v2 to API v3 - etcd
Migrating an application from the API v2 to the API v3 involves two steps: 1) migrate the client library and, 2) migrate the...
Read more >
Migrating from xDS v2 --> v3 - Project Contour
This guide shows you how to migrate in-place instances of Envoy running xDS v2 to v3. Summary. Envoy communicates with Contour over gRPC...
Read more >
Migrating from 2.x to 3.0 - Socket.IO
Update: As of Socket.IO 3.1.0, the v3 server is now able to communicate with v2 clients. More information below. A v3 client is...
Read more >
Migrating Winston Logger from 2.4.4 to 3.x... The new ...
So I'm trying to migrate from Winston 2.x to 3.x, however it comes with a rather large shift in setting up the transports...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found