customDay component is not rendered in v1.1279.0
See original GitHub issueDescription
The latest version of the library (1.1279.0) introduced a bug where the customDay
in calendars is unused.
I have identified the problem and will open a PR in a few minutes, using this issue as reference.
Expected Behavior
Passing the customDay
prop to a Calendar
component renders the custom day.
Observed Behavior
Passing the customDay
prop to a Calendar
component renders the default period day provided by this library.
Environment
N/A
Reproducible Demo
Reproducible in the example project provided by this library.
Issue Analytics
- State:
- Created 2 years ago
- Reactions:3
- Comments:12
Top Results From Across the Web
Why is my custom component not rendering in React Native?
I don't think so. Your component is nowhere with this setup. Your function just returns some JSX but your app does not know...
Read more >Testing React Components with Jest and Enzyme- In Depth
Everything is fine when I test a small component without logic, just UI rendering, but as practice shows, there are no such components...
Read more >How To Write Snapshot Tests For React Components With Jest
Write a test that renders the Items component with no items passed ... Jest Snapshot v1, https://goo.gl/fbAQLP exports[`renders correctly ...
Read more >Working with Shadow DOM - Lit.dev
Shadow DOM v1: Self-Contained Web Components on Web Fundamentals. ... Lit renders components to its renderRoot , which is a shadow root by...
Read more >React Native Calendar Components 🗓️ - BestofReactjs
The solution is implemented in JavaScript so no native module linking is required. ... you can pass your own custom day component to...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
dayComponent
component does not work either.I would suggest proper semantic versioning (https://semver.org). Now only the minor version is increased and every new version may either have bug fixes or breaking changes. Would be nice to see from the version number if it’s a hotfix, minor change or a major change. Now everything is just a minor change (totally 1279!). Also, breaking changes should be mentioned in the release notes.