Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Tile being a button element interferes with content

See original GitHub issue

Currently the Tile class is implemented with its base element as a button.

This causes issues with certain pieces of content, in my case I cannot put tooltips on any custom content within the tile.

Could we either change the base element to div or offer the option to do so?

Issue Analytics

State:
Created 5 years ago
Comments:6 (3 by maintainers)

Top GitHub Comments

1reaction

jonnycookcommented, Jun 2, 2020

I’m fairly certain <button> is the only way to go here. It’s an active element and accessibility is one of the key features of React-Calendar.

But what is the downside to giving users of your library the freedom to choose whether or not accessibility is a priority? Offering the ability to override a default setting does not negate the advantages of the default setting.

I understand using buttons as a default element, but I do not understand imposing that decision on your users.

0reactions

wojtekmajcommented, Jul 4, 2018

I can’t say how it would affect accessibility either so I’d rather play it safe. Sorry for that! You’re still welcome to make a fork if you would need this after all. We shouldn’t have too many (if any) conflicts 😃