inputRef gives an error when passed an object, but isn't working when passed a function

I’m trying to call the innerHeight of the Document after loading, using the inputRef. This works if i do:

const previewRef = useRef() <Document inputRef={previewRef} … />

However, I get the following error: index.js:1375 Warning: Failed prop type: Invalid prop inputRef of type object supplied to Document, expected function

But when I try to pass the ref in as a function: <Document inputRef={ ref => previewRef = ref} />

previewRef.current is undefined.

Am I missing something?

Thanks

[wojtekmaj]

@wojtekmaj what’s wrong with passing in the result of a React.createRef in v5?

After analysis, nothing really. At the moment of writing it’s only a problem in Page component, where inputRef is called like this:

https://github.com/wojtekmaj/react-pdf/blob/1f9ae5249aa2ff6f1c621d4867b5739388b4259e/src/Page.jsx#L366-L373

This, however, can easily be changed by using merge-refs library.

So that’s exactly what I did in b38ee57dea66f8801687662fd93cfa4374df7c03, which closes this issue.

[wojtekmaj]

Will need to wait for a while for a release, I’m having slight problems with manual testing lately.