Creating temporary library JAR directory fails if it already exists

Hi,

I’m using the plugin with the

<putLibraryJarsInTempDir>true</putLibraryJarsInTempDir>

option because of a large classpath. When running mvn proguard:proguard and when not having run mvn clean beforehand the temporary library directory (‘tempLibraryjars’) may already exist. If that’s the case then the following call to mkdir() will return false and the proguard plugin will throw an exception:

https://github.com/wvengen/proguard-maven-plugin/blob/master/src/main/java/com/github/wvengen/maven/proguard/ProGuardMojo.java#L580

Can you please ignore the return value of mkdir() and instead check for the existence of the directory after the call to mkdir(), followed by cleaning it?

Thanks.

[FibreFoX]

https://github.com/FibreFoX/proguard-maven-plugin/commit/9df7725b1141475bc21e32291d9ced8e42b3c76a

Will make another commit for deleting the contents first 😃 there should be some PR tomorrow

[snooper77]

Thanks, but I can’t do it from my work place and I don’t have maven/git set up at home. The change is trivial and looks like this:

Replace lines 580-582 in ProGuardMojo:

            if (!tempLibraryjarsDir.mkdir()) {
                throw new MojoFailureException("Can't create temporary libraryJars directory: " + tempLibraryjarsDir.getAbsolutePath());
            }

by:

            tempLibraryjarsDir.mkdir();
            if (!tempLibraryjarsDir.exists()) {
                throw new MojoFailureException("Can't create temporary libraryJars directory: " + tempLibraryjarsDir.getAbsolutePath());
            }