Make "redis" an optional dependency

I use rate-limit-redis with ioredis as my preferred Redis client library.

While inspecting my projects dependencies I noticed that rate-limit-redis has a hard dependency on the redis NPM package. From the documentation, rate-limit-redis is compatible with either ioredis or redis

I suggest making redis an optional dependency. This would allow consumers of rate-limit-redis to choose which Redis client(s) are installed.

[wyattjoh]

It’s certainly an interesting idea, but unfortunately, this would mean that every user of rate-limit-redis would need to add redis or ioredis to their dependencies themselves. This could be changed in a new major version, but I’d worry that the default behaviour still provides the easiest installation path.

Maybe a cleaner solution would be to introduce a new package that simply provides the rate-limit-redis interface only accepting the client and leave this package as one that includes the hard dependency on redis.

Does that sound like an ok solution going forward?

[stale[bot]]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.