question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Allow theme colors to be named colors?

See original GitHub issue

Currently named colors are ignored by themes

Details

  • Browser and browser version: Firefox 57
  • OS version: macOS 10.13
  • xterm.js version: 3.0.1

Steps to reproduce

  1. Apply named colors like 'white' to a theme
  2. Colors are not handled by _validateColor and fall back to the default

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
blink1073commented, Jan 8, 2018

You could use a dummy DOM node and set the value and make sure it reads back the same.

https://stackoverflow.com/a/28440897

0reactions
Tyriarcommented, Jan 9, 2018

Cool trick 👍

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to Name Custom colors & Themes? - Microsoft Community
Hi, i'm trying to create custom colors & themes for use in Word, PPT, Excel. In PPT, I go to Master>Colors>Create New Theme...
Read more >
How to name your colors in a Design System - UX Collective
Many Design Systems and CSS Frameworks use this convention to allow users to globally theme their app as they wish. Image of Semantically...
Read more >
theme-color - HTML: HyperText Markup Language | MDN
The theme-color value for the name attribute of the element indicates a suggested color that user agents should use to customize the display ......
Read more >
What do you name color variables? | CSS-Tricks
I first give a name to all the colors I use using that tool, for example “$color-cornflower-blue: #6195ED;” and then I create variables...
Read more >
Customize Your Site's Colors – WordPress.com Support
Click on the Colors & Backgrounds tab. On the next screen, you'll see the option named Colors. To see which colors are mapped...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found