question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Browser crash related to fit addon returning geometry with "Infinity" sizes

See original GitHub issue

screenshot 2018-04-25 18 34 47

Appears to be caused by edge cases around offscreen xterms coming/going onscreen. With term.renderer.dimensions.actualCellWidth as null, fit returns Infinity. If you allow xterm to try to resize itself to Infinity, it consumes all available RAM and crashes the browser.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Reactions:1
  • Comments:26 (22 by maintainers)

github_iconTop GitHub Comments

3reactions
vincentwoocommented, May 4, 2018

I just noticed the requirement that xterm has that the parent be visible when open is called. We might be in the wrong, here, so I’ll try to take a second look later.

0reactions
ioquatixcommented, May 15, 2018

1/ I think if the size is invalid, it should be an error.

2/ If the size is too big for the available computer memory, it should be an error too, not crash the browser.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Safari Technology Preview Release Notes - Apple Developer
Fixed a crash when calling browser.webNavigation.getAllFrames() on an empty tab; Fixed Active tab permissions for a tab to get removed if a matching ......
Read more >
USD/CHANGELOG.md at release · PixarAnimationStudios/USD
Updated TF_ERROR macros now return void instead of bool like the other ... Fixed crashes when reading .usda files containing certain strings ...
Read more >
Bug listing with status RESOLVED with resolution TEST ...
Bug:233 - "Emacs segfaults when merged through the sandbox." status:RESOLVED resolution:TEST-REQUEST severity:critical · Bug:3888 - "yenta_socket module not ...
Read more >
Issues Resolved | Revit 2022 - Autodesk Knowledge Network
DistributionOfNormals returns OnePerFace. Fixed an API issue where properties with no value would report a value in the UI.
Read more >
Bridge Software - PGSuper™ Release History - wsdot
Dimensions in the Girder View show nominal height at CL web. ... Fixed crash when defining girder due to errors with design strategy...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found