Browserified search addon includes a copy of Terminal

Regressed in https://github.com/sourcelair/xterm.js/pull/834

When browserify sees this:

module.exports = addon(require('../../xterm'));

It merges all of xterm into this file. One way to work around this is to pull the string out so browserify doesn’t pick it up:

const xterm = '../../xterm';
module.exports = addon(require(xterm));

This produces a warning in webpack:

WARNING in ../~/xterm/lib/addons/search/search.js
10:31-45 Critical dependency: the request of a dependency is an expression

This warning is preferable really, I wonder if there is a better way to build something (search addon) that depends on a lib (xterm.js) without packaging the lib with it.

[Tyriar]

Possible fix is for instead of search.ts to find Terminal.ts, have Terminal.loadAddon load the addon and then pass Terminal into it.

In search.ts:

    /**
     * CommonJS environment
     */
    module.exports = addon;

In Terminal.ts:

public static loadAddon(addon: string, callback?: Function): boolean | any {
    // TODO: Improve return type and documentation
    if (typeof exports === 'object' && typeof module === 'object') {
      // CommonJS
      return require('./addons/' + addon + '/' + addon)(Terminal);
    } else if (typeof define === 'function') {
...

[Tyriar]

I’m consolidating all bundling/loadAddon related issues into https://github.com/sourcelair/xterm.js/issues/1018, please comment on that issue if you have thoughts 😃